Skip to content

Add SAML subject identifier attributes to saml2_uri attributemap#607

Merged
c00kiemon5ter merged 1 commit into
IdentityPython:masterfrom
alexstuart:SAML-subject-id
Apr 15, 2019
Merged

Add SAML subject identifier attributes to saml2_uri attributemap#607
c00kiemon5ter merged 1 commit into
IdentityPython:masterfrom
alexstuart:SAML-subject-id

Conversation

@alexstuart

@alexstuart alexstuart commented Apr 14, 2019

Copy link
Copy Markdown
Contributor

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

Explanation

Two SAML subject identifier attributes have been recently defined in the OASIS SAML V2.0 Subject Identifier Attributes Profile Version 1.0 specifcation and they do not appear in pysaml2's attribute map. This PR is to add the attributes to saml_uri.py following the conventions in that file.

I have tested this change in a pysaml2+SATOSA deployment.

@codecov

codecov Bot commented Apr 14, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #607 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #607      +/-   ##
=========================================
- Coverage    65.6%   65.6%   -0.01%     
=========================================
  Files         103     103              
  Lines       25614   25615       +1     
=========================================
- Hits        16805   16804       -1     
- Misses       8809    8811       +2
Impacted Files Coverage Δ
src/saml2/attributemaps/saml_uri.py 100% <100%> (ø) ⬆️
src/saml2/validate.py 75.29% <0%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b397fc...6d611b7. Read the comment docs.

@c00kiemon5ter c00kiemon5ter merged commit d3aa78e into IdentityPython:master Apr 15, 2019
@c00kiemon5ter

c00kiemon5ter commented Apr 15, 2019

Copy link
Copy Markdown
Member

Thank you; keep in mind that in the future attributemaps will be completely removed.

@peppelinux

peppelinux commented Apr 15, 2019

Copy link
Copy Markdown
Member

Ho @c00kiemon5ter, why? How Will we do mapping without attrmaps? I saw that it works already whitout attrmaps, Just curiosity

@alexstuart

alexstuart commented Apr 21, 2019

Copy link
Copy Markdown
Contributor Author

Hello @c00kiemon5ter Thanks for merging that PR.

Where can I find out about future plans for pysaml2 attributemaps? I can't see anything relevant in the pysaml2-dev mailing list and I've not found a pysaml2 users mailing list.

Thanks!

@c00kiemon5ter

c00kiemon5ter commented Apr 24, 2019

Copy link
Copy Markdown
Member

Hi again, #549 explains why attributemaps will go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexstuart @c00kiemon5ter @peppelinux